Skip to content

fix: simplify redundant error-message assertion - #385

Merged
rng1995 merged 2 commits into
NVIDIA:mainfrom
andrewwhitecdw:codequality/test-cli-simplify-redundant-error-message
Aug 20, 2026
Merged

fix: simplify redundant error-message assertion#385
rng1995 merged 2 commits into
NVIDIA:mainfrom
andrewwhitecdw:codequality/test-cli-simplify-redundant-error-message

Conversation

@andrewwhitecdw

Copy link
Copy Markdown
Contributor

This PR addresses the following issue in tests/unit/test_cli.py: simplify redundant error-message assertion.

Changes

  • tests/unit/test_cli.py: simplify redundant error-message assertion.

Details

--- a/tests/unit/test_cli.py
+++ b/tests/unit/test_cli.py
@@ -1,1 +1,1 @@
-    assert "Error" in result.output or "error" in result.output.lower()
+    assert "error" in result.output.lower()

Tests

Let me know if you want tests added for this fix or not.

Contributor guidelines

Per this repo's CONTRIBUTING.md:

  • All commits are signed off (Signed-off-by trailer, DCO).

Signed-off-by: andrewwhitecdw <andrewwhitecdw@users.noreply.github.com>

@rng1995 rng1995 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[SkillSpector Review]

Approved. This is a behavior-preserving assertion simplification and required CI is green.

@rng1995
rng1995 enabled auto-merge (squash) August 20, 2026 22:59
@rng1995
rng1995 merged commit ab20368 into NVIDIA:main Aug 20, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants